feat: Translate more errors

Infomaniak · May 11, 2023 · 49265e9 · 49265e9
1 parent d44f3e1
commit 49265e9
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 6 deletions.
diff --git a/MailCore/API/MailApiError.swift b/MailCore/API/MailApiError.swift
@@ -38,7 +38,9 @@ class MailApiError: MailError {
             localizedDescription: MailResourcesStrings.Localizable.errorNewFolderAlreadyExists,
             shouldDisplay: true
         ),
-        MailApiError(code: "folder__not_exists"),
+        MailApiError(code: "folder__not_exists",
+                     localizedDescription: MailResourcesStrings.Localizable.errorFolderNotFound,
+                     shouldDisplay: true),
 
         // Mail
         MailApiError(code: "mail__move_destination_folder_not_found"),

diff --git a/MailCore/API/MailError.swift b/MailCore/API/MailError.swift
@@ -39,21 +39,27 @@ public class MailError: LocalizedError {
     public let errorDescription: String
     public let shouldDisplay: Bool
 
-    init(code: String, localizedDescription: String? = nil, shouldDisplay: Bool = false) {
+    init(code: String,
+         localizedDescription: String = MailResourcesStrings.Localizable.errorUnknown,
+         shouldDisplay: Bool = false) {
         self.code = code
-        errorDescription = localizedDescription ?? "Unknown error"
+        errorDescription = localizedDescription
         self.shouldDisplay = shouldDisplay
     }
 
     public static let unknownError = MailError(code: "unknownError", shouldDisplay: true)
     public static let noToken = MailError(code: "noToken", shouldDisplay: true)
     public static let resourceError = MailError(code: "resourceError", shouldDisplay: true)
     public static let unknownToken = MailError(code: "unknownToken", shouldDisplay: true)
-    public static let noMailbox = MailError(code: "noMailbox", shouldDisplay: true)
-    public static let folderNotFound = MailError(code: "folderNotFound", shouldDisplay: true)
+    public static let noMailbox = MailError(code: "noMailbox")
+    public static let folderNotFound = MailError(code: "folderNotFound",
+                                                 localizedDescription: MailResourcesStrings.Localizable.errorFolderNotFound,
+                                                 shouldDisplay: true)
     public static let addressBookNotFound = MailError(code: "addressBookNotFound", shouldDisplay: true)
     public static let contactNotFound = MailError(code: "contactNotFound", shouldDisplay: true)
-    public static let messageNotFound = MailError(code: "messageNotFound", shouldDisplay: true)
+    public static let messageNotFound = MailError(code: "messageNotFound",
+                                                  localizedDescription: MailResourcesStrings.Localizable.errorMessageNotFound,
+                                                  shouldDisplay: true)
     public static let attachmentsSizeLimitReached = MailError(code: "attachmentsSizeLimitReached",
                                                               localizedDescription: MailResourcesStrings.Localizable
                                                                   .attachmentFileLimitReached,

diff --git a/MailResources/Localizable/de.lproj/Localizable.strings b/MailResources/Localizable/de.lproj/Localizable.strings
diff --git a/MailResources/Localizable/en.lproj/Localizable.strings b/MailResources/Localizable/en.lproj/Localizable.strings
diff --git a/MailResources/Localizable/es.lproj/Localizable.strings b/MailResources/Localizable/es.lproj/Localizable.strings
diff --git a/MailResources/Localizable/fr.lproj/Localizable.strings b/MailResources/Localizable/fr.lproj/Localizable.strings
diff --git a/MailResources/Localizable/it.lproj/Localizable.strings b/MailResources/Localizable/it.lproj/Localizable.strings