Merge pull request #1258 from Infomaniak/fix-sheet-presentation

fix: Delay DefaultDiscoveryView after ComposeView dismiss
Infomaniak · Feb 5, 2024 · 84f864e · 84f864e
2 parents 467eed8 + ed864fa
commit 84f864e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/Mail/Views/New Message/ComposeMessageView.swift b/Mail/Views/New Message/ComposeMessageView.swift
@@ -316,7 +316,10 @@ struct ComposeMessageView: View {
         sendDraft()
 
         if !Bundle.main.isExtension {
-            mainViewState.isShowingSetAppAsDefaultDiscovery = UserDefaults.shared.shouldPresentSetAsDefaultDiscovery
+            // We should implement a proper router to avoid doing this
+            DispatchQueue.main.asyncAfter(deadline: UIConstants.modalCloseDelay) {
+                mainViewState.isShowingSetAppAsDefaultDiscovery = UserDefaults.shared.shouldPresentSetAsDefaultDiscovery
+            }
             if !mainViewState.isShowingSetAppAsDefaultDiscovery {
                 mainViewState.isShowingChristmasEasterEgg = true
             }

diff --git a/MailCore/Cache/Actions/ActionsManager.swift b/MailCore/Cache/Actions/ActionsManager.swift
@@ -149,7 +149,7 @@ public class ActionsManager: ObservableObject {
         case .print:
             guard let message = messages.first else { return }
             // Needed to be sure that the bottomView is dismissed before we try to show the printPanel
-            DispatchQueue.main.asyncAfter(deadline: .now() + 1) {
+            DispatchQueue.main.asyncAfter(deadline: UIConstants.modalCloseDelay) {
                 let nc = NotificationCenter.default
                 nc.post(name: Notification.Name.printNotification, object: message)
             }

diff --git a/MailCore/UI/UIConstants.swift b/MailCore/UI/UIConstants.swift
@@ -116,6 +116,10 @@ public extension UIConstants {
 public extension UIConstants {
     static let checkboxAppearDelay = 0.2
     static let checkboxDisappearOffsetDelay = 0.35
+
+    static var modalCloseDelay: DispatchTime {
+        DispatchTime.now() + 0.75
+    }
 }
 
 // MARK: - Utils