chore: PR Feedback. (IKSnackBarAvoider/ShareViewController)

Infomaniak · Aug 2, 2023 · 86ca4ae · 86ca4ae
1 parent 60ac406
commit 86ca4ae
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 25 deletions.
diff --git a/Mail/Helpers/AppAssembly.swift b/Mail/Helpers/AppAssembly.swift
@@ -67,8 +67,8 @@ enum ApplicationAssembly {
             Factory(type: MatomoUtils.self) { _, _ in
                 MatomoUtils(siteId: Constants.matomoId, baseURL: URLConstants.matomo.url)
             },
-            Factory(type: SnackBarAvoider.self) { _, _ in
-                SnackBarAvoider()
+            Factory(type: IKSnackBarAvoider.self) { _, _ in
+                IKSnackBarAvoider()
             },
             Factory(type: DraftManager.self) { _, _ in
                 DraftManager()

diff --git a/Mail/Utils/SnackBarAwareModifier.swift b/Mail/Utils/SnackBarAwareModifier.swift
@@ -21,7 +21,7 @@ import MailCore
 import SwiftUI
 
 struct SnackBarAwareModifier: ViewModifier {
-    @InjectService var avoider: SnackBarAvoider
+    @InjectService var avoider: IKSnackBarAvoider
     var inset: CGFloat {
         didSet {
             avoider.addAvoider(inset: inset)

diff --git a/MailCore/Utils/SnackBar/IKSnackBar+Extension.swift b/MailCore/Utils/SnackBar/IKSnackBar+Extension.swift
@@ -41,23 +41,6 @@ public extension SnackBarStyle {
     }
 }
 
-// TODO: delete
-public final class SnackBarAvoider {
-    public var snackBarInset: CGFloat = 0
-
-    public init() { /* Needed to init */ }
-
-    public func addAvoider(inset: CGFloat) {
-        if inset != snackBarInset {
-            snackBarInset = inset
-        }
-    }
-
-    public func removeAvoider() {
-        snackBarInset = 0
-    }
-}
-
 public extension IKSnackBar {
     @discardableResult
     @MainActor
@@ -76,7 +59,7 @@ public extension IKSnackBar {
         anchor _: CGFloat = 0,
         contextView: UIView? = nil
     ) -> IKSnackBar? {
-        @LazyInjectService var avoider: SnackBarAvoider
+        @LazyInjectService var avoider: IKSnackBarAvoider
 
         let snackbar: IKSnackBar?
         if let contextView = contextView {

diff --git a/MailShareExtension/ShareViewController.swift b/MailShareExtension/ShareViewController.swift
@@ -66,10 +66,12 @@ final class ShareNavigationViewController: UIViewController {
         }
 
         // We need to go threw wrapping to use SwiftUI in an NSExtension.
-        let hostingController = UIHostingController(rootView: ComposeMessageWrapperView(dismissHandler: {
-                                                                                            self.dismiss(animated: true)
-                                                                                        },
-                                                                                        itemProviders: itemProviders))
+        let rootView = ComposeMessageWrapperView(dismissHandler: {
+                                                     self.dismiss(animated: true)
+                                                 },
+                                                 itemProviders: itemProviders)
+            .defaultAppStorage(.shared)
+        let hostingController = UIHostingController(rootView: rootView)
         hostingController.view.translatesAutoresizingMaskIntoConstraints = false
         addChild(hostingController)
         view.addSubview(hostingController.view)