Skip to content

Commit

Permalink
refactor: Move constants to UIConstants
Browse files Browse the repository at this point in the history
  • Loading branch information
valentinperignon committed Apr 4, 2023
1 parent 5b4444c commit b650939
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 10 deletions.
14 changes: 4 additions & 10 deletions Mail/Views/Menu Drawer/MenuDrawerView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ class NavigationDrawerState: ObservableObject {
}

struct NavigationDrawer: View {
private let maxWidth = 350.0
private let spacing = 60.0

let mailboxManager: MailboxManager

@EnvironmentObject var splitViewManager: SplitViewManager
Expand Down Expand Up @@ -94,13 +91,10 @@ struct NavigationDrawer: View {

GeometryReader { geometryProxy in
HStack {
MenuDrawerView(
mailboxManager: mailboxManager,
isCompact: true
)
.frame(maxWidth: maxWidth)
.padding(.trailing, spacing)
.offset(x: navigationDrawerState.isOpen ? offsetWidth : -geometryProxy.size.width)
MenuDrawerView(mailboxManager: mailboxManager, isCompact: true)
.frame(maxWidth: UIConstants.menuDrawerMaxWidth)
.padding(.trailing, UIConstants.menuDrawerTrailingSpacing)
.offset(x: navigationDrawerState.isOpen ? offsetWidth : -geometryProxy.size.width)
Spacer()
}
}
Expand Down
2 changes: 2 additions & 0 deletions MailCore/UI/UIConstants.swift
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ public enum UIConstants {
public static let onboardingBottomButtonPadding: CGFloat = 32
public static let onboardingArrowIconSize: CGFloat = 24

public static let menuDrawerMaxWidth: CGFloat = 350
public static let menuDrawerTrailingSpacing: CGFloat = 60
public static let menuDrawerHorizontalPadding: CGFloat = 20
public static let menuDrawerVerticalPadding: CGFloat = 12
public static let menuDrawerSubFolderPadding: CGFloat = 15
Expand Down

0 comments on commit b650939

Please sign in to comment.