Revert "feat: send an error to sentry on date parsing issue"

.package.resolved

@@ -41,7 +41,7 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/Infomaniak/ios-core",
       "state" : {
-        "revision" : "307e6cb8da9ad0cf02aa3502492596c082d5247d"
+        "revision" : "025c5dffa801d0ffe4e55730897466784f42564f"
       }
     },
     {

MailCore/Models/Message.swift

@@ -20,7 +20,6 @@ import Foundation
 import InfomaniakCore
 import MailResources
 import RealmSwift
-import Sentry
 
 // TODO: move to core
 public extension String {
@@ -146,11 +145,6 @@ public enum MessageDKIM: String, Codable, PersistableEnum {
 }
 
 public final class Message: Object, Decodable, Identifiable {
-    public enum ErrorDomain: Error {
-        /// Unable to create a date from the input data
-        case dateParsingFailed
-    }
-
     @Persisted(primaryKey: true) public var uid = ""
     @Persisted public var messageId: String?
     @Persisted public var subject: String?
@@ -323,28 +317,7 @@ public final class Message: Object, Decodable, Identifiable {
             self.date = date
         } else {
             date = Date()
-            let dateParsingError = Event(level: .error)
-
-            let breadcrumb = SentryDebug.createBreadcrumb(
-                level: .warning,
-                category: "Thread algo",
-                message: "Nil message date decoded",
-                data: ["uid": uid]
-            )
-
-            SentrySDK.capture(error: ErrorDomain.dateParsingFailed) { scope in
-                if let date = try? values.decode(String.self, forKey: .date) {
-                    scope.setExtra(value: date, key: "dateString")
-                }
-
-                if let date = try? values.decode(Data.self, forKey: .date) {
-                    scope.setExtra(value: date, key: "dateRaw")
-                }
-
-                scope.addBreadcrumb(breadcrumb)
-            }
-
-            SentrySDK.addBreadcrumb(breadcrumb)
+            SentryDebug.nilDateParsingBreadcrumb(uid: uid)
         }
         size = try values.decode(Int.self, forKey: .size)
         from = try values.decode(List<Recipient>.self, forKey: .from)
@@ -373,9 +346,7 @@ public final class Message: Object, Decodable, Identifiable {
         if let inReplyTo = try? values.decodeIfPresent(String.self, forKey: .inReplyTo) {
             self.inReplyTo = inReplyTo
         } else if let inReplyToList = try values.decodeIfPresent([String].self, forKey: .inReplyTo) {
-            SentrySDK.capture(message: "Found an array of inReplyTo") { scope in
-                scope.setContext(value: ["ids": inReplyToList.joined(separator: ", ")], key: "inReplyToList")
-            }
+            SentryDebug.messageHasInReplyTo(inReplyToList)
             inReplyTo = inReplyToList.first
         }
 

MailCore/Utils/SentryDebug.swift

@@ -21,6 +21,8 @@ import RealmSwift
 import Sentry
 
 public enum SentryDebug {
+    // MARK: - Errors
+
     public static let knownDebugDate = Date(timeIntervalSince1970: 1_893_456_000)
     static func sendMissingMessagesSentry(sentUids: [String], receivedMessages: [Message], folder: Folder, newCursor: String?) {
         if receivedMessages.count != sentUids.count {
@@ -85,17 +87,6 @@ public enum SentryDebug {
         }
     }
 
-    static func createBreadcrumb(level: SentryLevel,
-                                 category: String,
-                                 message: String,
-                                 data: [String: Any]? = nil) -> Breadcrumb {
-        let crumb = Breadcrumb(level: level, category: category)
-        crumb.type = level == .info ? "info" : "error"
-        crumb.message = message
-        crumb.data = data
-        return crumb
-    }
-
     static func captureWrongDate(step: String, startDate: Date, folder: Folder, alreadyWrongIds: [String], realm: Realm) -> Bool {
         guard let freshFolder = folder.fresh(using: realm) else { return false }
 
@@ -134,4 +125,35 @@ public enum SentryDebug {
             )
         }
     }
+
+    static func messageHasInReplyTo(_ inReplyToList: [String]) {
+        SentrySDK.capture(message: "Found an array of inReplyTo") { scope in
+            scope.setContext(value: ["ids": inReplyToList.joined(separator: ", ")], key: "inReplyToList")
+        }
+    }
+
+    // MARK: - Breadcrumb
+
+    enum Category {
+        static let ThreadAlgorithm = "Thread algo"
+    }
+
+    private static func createBreadcrumb(level: SentryLevel,
+                                         category: String,
+                                         message: String,
+                                         data: [String: Any]? = nil) -> Breadcrumb {
+        let crumb = Breadcrumb(level: level, category: category)
+        crumb.type = level == .info ? "info" : "error"
+        crumb.message = message
+        crumb.data = data
+        return crumb
+    }
+
+    static func nilDateParsingBreadcrumb(uid: String) {
+        let breadcrumb = createBreadcrumb(level: .warning,
+                                          category: Category.ThreadAlgorithm,
+                                          message: "Nil message date decoded",
+                                          data: ["uid": uid])
+        SentrySDK.addBreadcrumb(breadcrumb)
+    }
 }