Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NavBar with long title #1019

Merged
merged 2 commits into from
Oct 9, 2023
Merged

fix: NavBar with long title #1019

merged 2 commits into from
Oct 9, 2023

Conversation

Lnamw
Copy link
Contributor

@Lnamw Lnamw commented Oct 4, 2023

No description provided.

@Lnamw Lnamw marked this pull request as ready for review October 5, 2023 07:30
@Lnamw Lnamw requested a review from a team as a code owner October 5, 2023 07:30
@Lnamw Lnamw self-assigned this Oct 5, 2023
valentinperignon
valentinperignon reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@valentinperignon valentinperignon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions about how the toolbar works and the proposed fix.. We'll talk about it monday! 😊

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@valentinperignon valentinperignon merged commit 949b663 into master Oct 9, 2023
7 checks passed
@valentinperignon valentinperignon deleted the fix-navBar branch October 9, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lnamw @valentinperignon