Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Clean message body #1141

Merged
merged 4 commits into from
Dec 6, 2023
Merged

fix: Clean message body #1141

merged 4 commits into from
Dec 6, 2023

Conversation

valentinperignon
Copy link
Member

No description provided.

@valentinperignon valentinperignon force-pushed the clean-body-update branch 3 times, most recently from 1d3c8c1 to 3292b9d Compare November 30, 2023 14:42
@valentinperignon valentinperignon marked this pull request as ready for review December 4, 2023 16:41
@valentinperignon valentinperignon requested a review from a team as a code owner December 4, 2023 16:41
adrien-coye
adrien-coye previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added a remark about using async functions. Let me know what you think.

MailCore/Utils/SwiftSoupUtils.swift Show resolved Hide resolved
adrien-coye
adrien-coye reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of remarks, thanks for the changes 🙏

MailCore/Utils/SwiftSoupUtils.swift Show resolved Hide resolved
MailCore/Utils/NotificationsHelper.swift Show resolved Hide resolved
MailCore/Models/Draft.swift Show resolved Hide resolved
MailCore/Cache/DraftContentManager.swift Outdated Show resolved Hide resolved
MailCore/Cache/DraftContentManager.swift Outdated Show resolved Hide resolved
Mail/Views/Thread/WebView/WebViewModel+SwiftSoup.swift Show resolved Hide resolved
Mail/Views/AI Writer/Proposition/AIPropositionView.swift Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

adrien-coye
adrien-coye approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, I did a quick manual testing pass, including draft creation / sending and also the share ext.

@valentinperignon valentinperignon merged commit 37a3c09 into master Dec 6, 2023
7 checks passed
@valentinperignon valentinperignon deleted the clean-body-update branch December 6, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees

@valentinperignon valentinperignon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valentinperignon @adrien-coye