Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RichTextEditor): Insert quote correctly #1165

Merged
merged 11 commits into from
Dec 13, 2023
Merged

feat(RichTextEditor): Insert quote correctly #1165

merged 11 commits into from
Dec 13, 2023

Conversation

valentinperignon
Copy link
Member

@valentinperignon valentinperignon commented Dec 6, 2023 •
edited
Loading

  • We need to insert raw HTML into the editor as the Squire function sanitize the input
  • We only keep the inner body HTML + style from head of the replying message

✅ Depends on #1170
✅ Depends on Infomaniak/SQRichTextEditor#1

@valentinperignon valentinperignon force-pushed the fix-quote-message branch 3 times, most recently from 574c783 to 317652a Compare December 8, 2023 10:49
@valentinperignon valentinperignon changed the base branch from master to refactor-draft-content-manager December 8, 2023 10:50
Base automatically changed from refactor-draft-content-manager to master December 8, 2023 12:02
@github-actions github-actions bot removed the dependent label Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

This PR/issue depends on:

@valentinperignon valentinperignon force-pushed the fix-quote-message branch 2 times, most recently from 8afe1f0 to b9a7617 Compare December 12, 2023 14:38
@valentinperignon valentinperignon marked this pull request as ready for review December 13, 2023 10:09
@valentinperignon valentinperignon requested a review from a team as a code owner December 13, 2023 10:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@PhilippeWeidmann PhilippeWeidmann merged commit f16c150 into master Dec 13, 2023
6 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the fix-quote-message branch December 13, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees

@valentinperignon valentinperignon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valentinperignon @PhilippeWeidmann