-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Share attachment to kdrive #1182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good 👍
I added a couple of comments regarding code that could be moved to ios-core
Do not merge before kDrive's part is in available in prod. |
I did a review, it looks good to me. Philippe will give the final go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Once the merge conflict is resolved wait for kDrive before merging.
7b1c3ad
to
de17df2
Compare
Depends on Infomaniak/ios-kDrive#1087 merged today. |
de17df2
to
bdbd3a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good 👍
a3f1437
to
3dd163f
Compare
|
No description provided.