Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Share attachment to kdrive #1182

Merged
merged 7 commits into from
Jan 29, 2024
Merged

feat: Share attachment to kdrive #1182

merged 7 commits into from
Jan 29, 2024

Conversation

Ambrdctr
Copy link
Contributor

No description provided.

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good 👍

I added a couple of comments regarding code that could be moved to ios-core

Mail/Proxy/Protocols/URLOpenable.swift Outdated Show resolved Hide resolved
Mail/Views/Attachment/AttachmentPreview.swift Outdated Show resolved Hide resolved
Mail/Views/Attachment/AttachmentPreview.swift Outdated Show resolved Hide resolved
Mail/Views/Attachment/AttachmentPreview.swift Outdated Show resolved Hide resolved
MailShareExtension/Proxy/URLOpener.swift Show resolved Hide resolved
@PhilippeWeidmann
Copy link
Member

PhilippeWeidmann commented Jan 8, 2024

Do not merge before kDrive's part is in available in prod.
(Related PR Infomaniak/ios-kDrive#1087)

@adrien-coye
Copy link
Contributor

I did a review, it looks good to me. Philippe will give the final go.

Copy link
Member

@PhilippeWeidmann PhilippeWeidmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Once the merge conflict is resolved wait for kDrive before merging.

@adrien-coye
Copy link
Contributor

Depends on Infomaniak/ios-kDrive#1087 merged today.
Available in kDrive 4.4.0

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@PhilippeWeidmann PhilippeWeidmann merged commit 3b43a80 into master Jan 29, 2024
5 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the file-sharing branch January 29, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants