feat: Attachment title will be used to populate Draft Subject #1227
Conversation
|
|
|
||
| if disposition == .inline, |
There was a problem hiding this comment.
This was dead code, so removed it. I now return the title instead
| @@ -38,27 +38,32 @@ extension NSItemProvider: Attachable { | |||
| return UTType(preferredIdentifier) | |||
| } | |||
|
|
|||
| public func writeToTemporaryURL() async throws -> URL { | |||
| public func writeToTemporaryURL() async throws -> (url: URL, title: String?) { | |||
There was a problem hiding this comment.
maybe a marginal improvement using a typealias for this (url: URL, title: String?)
| @@ -88,6 +88,25 @@ public final class AttachmentsManagerWorker { | |||
| liveAttachments.map { $0.detached() } | |||
| } | |||
|
|
|||
| var attachmentsTitles: [String?]? { | |||
There was a problem hiding this comment.
maybe some doc about the DB modified on side effect
|
I tested the feature on iPhone8 iOS16.7 all good. Removing draft status. |
|
I think users were expecting something more like this: |
|
I tried to match the behaviour of Android that does not just work for webpages, therefore I did what was to me the most pragmatic first step. The good thing is that what you are sharing can be added later @PhilippeWeidmann |
*** conditions may apply, depends on type of underlying NSItemProvider.