fix: Improve sentry error logging #1394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier to read commit by commit.
shouldSendToSentry:
I extracted logic to choose whether we should send the events or not ->
shouldSendToSentry
Errors are now sent only if:
MailError encodable
MailErrors are now encodable to improve their readability in Sentry
Deprecated symbols
Some deprecated Sentry calls where replaced
Silenced warnings
Warnings regarding casting of some errors in Sentry's
context
are now handled correctly