Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use transaction based APIs for Mail #1398

Merged
merged 10 commits into from
Apr 30, 2024
Merged

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Apr 25, 2024

Abstact

In order to strengthen the Write transactions in kDrive a new module (coreDB) and a new abstraction was developed (Transactionable)

This PR brings back the progress made on Drive and brings it back to Mail.

The kDrive PR is here with further details : Infomaniak/ios-kDrive#1167

@adrien-coye adrien-coye changed the title refactor: Use base protocols of coreDB to to build a MailRealmAccessible refactor: Use transaction based APIs for Mail Apr 25, 2024
@adrien-coye adrien-coye marked this pull request as ready for review April 26, 2024 12:38
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a self review and added some notes to help reviewers.

Copy link
Member

@PhilippeWeidmann PhilippeWeidmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrien-coye adrien-coye deleted the transactionAPI branch April 30, 2024 07:33
@adrien-coye adrien-coye restored the transactionAPI branch April 30, 2024 07:33
@adrien-coye adrien-coye reopened this Apr 30, 2024
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adrien-coye adrien-coye merged commit 09b3664 into master Apr 30, 2024
12 checks passed
@adrien-coye adrien-coye deleted the transactionAPI branch April 30, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants