-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Small fixes for macOS #1456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aff0611
to
5897b1e
Compare
Found 56 unused code occurences Expand
|
5897b1e
to
4f4b7d6
Compare
4f4b7d6
to
b4f46c8
Compare
|
Ambrdctr
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read commit by commit:
fix: Manually pass environmentObject to ContactActionsView
-> ensure we correctly pass the env on macOSfix(SelectedMailboxView): Do not depend on EnvironmentObject for mailboxmanager
-> ensure we have a mailboxManager (and the correct one) for each cellfix: Add MenuHeaderView to toolbar only on macOS
-> add the MenuHeaderView elements directly to the menu bar