Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Share mail link #1483

Merged
merged 10 commits into from
Jul 11, 2024
Merged

feat: Share mail link #1483

merged 10 commits into from
Jul 11, 2024

Conversation

Lnamw
Copy link
Contributor

@Lnamw Lnamw commented Jul 10, 2024 •
edited
Loading

TODO

  • New action on message: Share mail
  • New request: POST api/mail/{{mailbox_uuid}}/folder/{{folder_uid}}/message/{{mail_id}}/share -> Return a String url to share
  • Display Sharesheet

More info

  • Link expires after 30 days
  • If user create a new link for the same message, old one is automatically disabled
  • For later in V2: "Revoke link" as shown on Figma

Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-07-10 at 09 56 53t Simulator Screenshot - iPhone 15 Pro - 2024-07-10 at 10 01 04

@Lnamw Lnamw changed the title Feat: Share mail link feat: Share mail link Jul 10, 2024
@github-actions GitHub Actions
Copy link

Found 0 unused code occurences

Expand 
* No unused code detected.

@Lnamw Lnamw marked this pull request as ready for review July 10, 2024 08:36
@PhilippeWeidmann PhilippeWeidmann self-requested a review July 11, 2024 08:09
Lnamw and others added 2 commits July 11, 2024 10:34
@Lnamw @PhilippeWeidmann
fix: Commit suggestion
25cfc2f 
Co-authored-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
@Lnamw
fix: SwiftFormat
fecc7e4
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@PhilippeWeidmann PhilippeWeidmann merged commit 73339e2 into master Jul 11, 2024
8 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the share-mail-link branch July 11, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees

@Lnamw Lnamw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lnamw @PhilippeWeidmann