Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move UI constants to UIConstants enum #668

Merged
merged 1 commit into from
Mar 31, 2023
Merged

refactor: move UI constants to UIConstants enum #668

merged 1 commit into from
Mar 31, 2023

Conversation

valentinperignon
Copy link
Member

@valentinperignon valentinperignon commented Mar 30, 2023 •
edited
Loading

Some constants could later be moved in Core sush as mailRegex

Closes #305

@valentinperignon valentinperignon requested a review from a team as a code owner March 30, 2023 08:51
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ambrdctr Ambrdctr merged commit 53be76e into master Mar 31, 2023
@Ambrdctr Ambrdctr deleted the refactor-constants branch March 31, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

@Ambrdctr Ambrdctr Ambrdctr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split Constant into UIConstant and Constant (like kDrive)
3 participants
@valentinperignon @PhilippeWeidmann @Ambrdctr