Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update matomo events #679

Merged
merged 1 commit into from
Apr 5, 2023
Merged

chore: Update matomo events #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Mail/Views/Bottom sheets/Actions/ActionsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ enum ActionsTarget: Equatable {
globalSheet.close()
if let matomoCategory, let matomoName = action.matomoName {
if case let .threads(threads, isMultipleSelectionEnabled) = target, isMultipleSelectionEnabled {
matomo.trackBulkEvent(eventWithCategory: matomoCategory, name: matomoName, numberOfItems: threads.count)
matomo.trackBulkEvent(eventWithCategory: matomoCategory, name: matomoName.capitalized, numberOfItems: threads.count)
} else {
matomo.track(eventWithCategory: matomoCategory, name: matomoName)
}
Expand Down
2 changes: 1 addition & 1 deletion Mail/Views/Thread List/FlushFolderAlertView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ struct FlushFolderAlertView: View {
secondaryButtonTitle: MailResourcesStrings.Localizable.buttonClose) {
if let folder, flushAlert.deletedMessages == nil {
@InjectService var matomo: MatomoUtils
matomo.track(eventWithCategory: .threadList, name: "empty\(folder.matomoName)Confirm")
matomo.track(eventWithCategory: .threadList, name: "empty\(folder.matomoName.capitalized)Confirm")
}
Task {
await flushAlert.completion()
Expand Down
2 changes: 1 addition & 1 deletion Mail/Views/Thread List/ThreadListMultipleSectionViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ import SwiftUI

func didTap(action: Action, flushAlert: Binding<FlushAlertState?>) async throws {
if let matomoName = action.matomoName {
matomo.trackBulkEvent(eventWithCategory: .threadActions, name: matomoName, numberOfItems: selectedItems.count)
matomo.trackBulkEvent(eventWithCategory: .threadActions, name: matomoName.capitalized, numberOfItems: selectedItems.count)
}
switch action {
case .markAsRead, .markAsUnread:
Expand Down