Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SearchView #680

Merged
merged 12 commits into from
Apr 5, 2023
Merged

fix: SearchView #680

merged 12 commits into from
Apr 5, 2023

Conversation

PhilippeWeidmann
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann commented Apr 5, 2023 •
edited
Loading

  • Fix folder selection
  • Remove nil folder
  • Prevent crash on filter selection
  • Prevent crash reload list

@PhilippeWeidmann PhilippeWeidmann requested a review from a team as a code owner April 5, 2023 08:09
@PhilippeWeidmann PhilippeWeidmann marked this pull request as draft April 5, 2023 08:10
@PhilippeWeidmann PhilippeWeidmann marked this pull request as ready for review April 5, 2023 12:50
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@valentinperignon valentinperignon merged commit c8d664a into master Apr 5, 2023
@valentinperignon valentinperignon deleted the fix-search branch April 5, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon approved these changes

@Ambrdctr Ambrdctr Ambrdctr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PhilippeWeidmann @valentinperignon @Ambrdctr