Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use native panels #720

Merged
merged 32 commits into from
May 3, 2023
Merged

refactor: Use native panels #720

merged 32 commits into from
May 3, 2023

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

@PhilippeWeidmann PhilippeWeidmann marked this pull request as ready for review May 1, 2023 09:16
@PhilippeWeidmann PhilippeWeidmann requested a review from a team as a code owner May 1, 2023 09:16
valentinperignon
valentinperignon reviewed May 1, 2023
View reviewed changes
Mail/Views/Thread/MessageHeaderView.swift Outdated Show resolved Hide resolved
Mail/Views/Thread/ThreadView.swift Outdated Show resolved Hide resolved
@PhilippeWeidmann PhilippeWeidmann force-pushed the refactor-panels branch 2 times, most recently from f8df3f1 to 5a5ddae Compare May 2, 2023 14:31
@PhilippeWeidmann
refactor(SheetView): This is now a SheetViewModifier
1287d77 
(Is there something left that I didn't refactor? :pls:)
@PhilippeWeidmann
fix(ActionsViewModel): Also dispatch moveAction
9b603f1
@PhilippeWeidmann
Merge branch 'master' into refactor-panels
4ccb110 
# Conflicts:
#	Mail/Views/Bottom sheets/Actions/ActionsViewModel.swift
@Infomaniak Infomaniak deleted a comment from sonarcloud bot May 3, 2023
Ambrdctr
Ambrdctr previously approved these changes May 3, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ambrdctr Ambrdctr merged commit 5e93ed7 into master May 3, 2023
4 checks passed
@Ambrdctr Ambrdctr deleted the refactor-panels branch May 3, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon left review comments

@Ambrdctr Ambrdctr Ambrdctr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PhilippeWeidmann @valentinperignon @Ambrdctr