Inline images mail slow to display #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
commented
May 25, 2023
adrien-coye
commented
May 25, 2023
adrien-coye
commented
May 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Ambrdctr
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Performance issues on displaying large emails with inline pictures.
The mainthread was pinned, batching image processing greatly improves the UX in my testing.
Misc
Mutating the dom of the email is super costly, therefore I used batching to process images and mutate less the content of the email view that is rendered on the main thread.
I went from 300 sec to 50 ish for a mail with a lot of small images, while keeping the UI responsive