Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: truncate email too long for Realm #770

Merged
merged 14 commits into from
Jun 9, 2023
Merged

feat: truncate email too long for Realm #770

merged 14 commits into from
Jun 9, 2023

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Jun 2, 2023 •
edited
Loading

Features

  • Truncate email too long, right now at 10MB.
  • Main mail message is compressed with lzfse (zstd like), to reduce presure on realm.

Dependency

@adrien-coye adrien-coye self-assigned this Jun 2, 2023
@adrien-coye adrien-coye marked this pull request as ready for review June 6, 2023 08:27
@adrien-coye adrien-coye requested a review from a team as a code owner June 6, 2023 08:27
@PhilippeWeidmann PhilippeWeidmann self-requested a review June 6, 2023 10:45
valentinperignon
valentinperignon reviewed Jun 9, 2023
View reviewed changes
MailCore/Models/Draft.swift Outdated Show resolved Hide resolved
MailCore/Models/Message.swift Outdated Show resolved Hide resolved
adrien-coye and others added 2 commits June 9, 2023 14:24
@adrien-coye @valentinperignon
Update MailCore/Models/Draft.swift
ff4b6a6 
Co-authored-by: Valentin Perignon <valentin.perignon@infomaniak.com>
@adrien-coye @valentinperignon
Update MailCore/Models/Message.swift
d8113fa 
Co-authored-by: Valentin Perignon <valentin.perignon@infomaniak.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adrien-coye adrien-coye merged commit ef4fcc2 into master Jun 9, 2023
5 checks passed
@adrien-coye adrien-coye deleted the entropyMaximizer branch June 9, 2023 12:29
@adrien-coye
Copy link
Contributor Author

FTR, branch should have been named entropyMinimizer as this is data, not a gas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon approved these changes

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann left review comments

Assignees

@adrien-coye adrien-coye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrien-coye @PhilippeWeidmann @valentinperignon