Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Current toolbar break when the screen is too small #771

Merged
merged 12 commits into from
Jun 7, 2023
Merged

fix: Current toolbar break when the screen is too small #771

merged 12 commits into from
Jun 7, 2023

Conversation

valentinperignon
Copy link
Member

@valentinperignon valentinperignon commented Jun 5, 2023 •
edited
Loading

We have 5 items on our bottom bar. With a small screen, the layout is broken, so we now use our own component.

@valentinperignon valentinperignon force-pushed the fix-thread-toolbar branch 3 times, most recently from 4cf7dc2 to 5c43708 Compare June 6, 2023 06:52
@valentinperignon valentinperignon changed the title fix: Update toolbar style according to its size fix: Current toolbar break when the screen is too small Jun 6, 2023
@valentinperignon valentinperignon marked this pull request as ready for review June 6, 2023 14:33
@valentinperignon valentinperignon requested a review from a team as a code owner June 6, 2023 14:33
@valentinperignon valentinperignon marked this pull request as draft June 7, 2023 06:12
@valentinperignon valentinperignon marked this pull request as ready for review June 7, 2023 06:24
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

adrien-coye
adrien-coye approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed in DM, all good

@valentinperignon valentinperignon merged commit cfd23c9 into master Jun 7, 2023
5 checks passed
@valentinperignon valentinperignon deleted the fix-thread-toolbar branch June 7, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

@PhilippeWeidmann PhilippeWeidmann Awaiting requested review from PhilippeWeidmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valentinperignon @adrien-coye