Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Selection and multiple selection should have the same vertical padding #774

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

valentinperignon
Copy link
Member

@valentinperignon valentinperignon commented Jun 6, 2023

Currently on iPad the selection background (gray color) and the multiple selection background (pink color) have different vertical padding.
It results in backgrounds with different heights.

@valentinperignon valentinperignon requested a review from a team as a code owner June 6, 2023 12:04
@valentinperignon valentinperignon changed the title fix: Selection and multiple selection should have the same vertical p… fix: Selection and multiple selection should have the same vertical padding Jun 6, 2023
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adrien-coye adrien-coye merged commit 3a34888 into master Jun 6, 2023
5 checks passed
@adrien-coye adrien-coye deleted the fix-selection-background branch June 6, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants