Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update ComposeMessageView #814

Merged
merged 41 commits into from
Jun 20, 2023
Merged

feat: Update ComposeMessageView #814

merged 41 commits into from
Jun 20, 2023

Conversation

valentinperignon
Copy link
Member

No description provided.

@valentinperignon valentinperignon mentioned this pull request Jun 16, 2023
Closed
@valentinperignon
feat: Create and present ComposeView v2
7d83888
@valentinperignon
feat: Display toolbar with buttons and title
6661563
@valentinperignon
feat: Divide in several files
207e524
@valentinperignon
feat: Create different cells
bf68134
@valentinperignon
feat: Fold cells
8f001fd
@valentinperignon
feat: Create view with draft
09643ac
@valentinperignon
feat: Create body and init
a6640a2
@valentinperignon
feat: Add message editor
461a0f7
@valentinperignon
feat: Import attachments
0544c20
@valentinperignon
feat: Move some computed properties to V2
de6d6e0
@valentinperignon
feat: Send or dismiss draft
56c25e3
@valentinperignon
feat: Prepare body
c4a38dd
@valentinperignon
feat: Sync draft on disappear
eb5865d
@valentinperignon
fix: Correct UITextField size
48439a6
@valentinperignon
refactor: Create new views and handle focus
f8862e1
@valentinperignon
feat: Handle autocompletion visibilty
14852fe
@valentinperignon
feat: Update autocompletion
ac5b554
@valentinperignon
fix: Update views properties
5138a8a
@valentinperignon
feat: Add custom recipient
f0e9f23
@valentinperignon
feat: Highlight recipient string
5ff2a59
@valentinperignon
feat: Create all ComposeView inits
b7a59e1
@valentinperignon
feat: Update recipients states
175acfc
@valentinperignon
refactor: Clean ComposeMessageV2 code
f10d331
@valentinperignon
feat: Display loading overlay
c86fe14
@valentinperignon
feat: Get focus when touch field
1ebd518
@valentinperignon
refactor: Remove old ComposeMessageView
15b5ca8
@valentinperignon
refactor: Remove old compenents
0c3b4d8
@valentinperignon valentinperignon mentioned this pull request Jun 20, 2023
Closed
@valentinperignon valentinperignon marked this pull request as ready for review June 20, 2023 07:14
@valentinperignon valentinperignon requested a review from a team as a code owner June 20, 2023 07:14
@valentinperignon valentinperignon requested review from PhilippeWeidmann and adrien-coye and removed request for a team June 20, 2023 07:33
adrien-coye
adrien-coye previously approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the code, It looks good honestly.

I have just one optional remark regarding debouncing, let me know what you think.
Thanks 👍

Mail/Views/New Message/AutocompletionView.swift Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PhilippeWeidmann PhilippeWeidmann merged commit d04f7a2 into master Jun 20, 2023
5 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the composemessageview-v2 branch June 20, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye left review comments

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@valentinperignon @PhilippeWeidmann @adrien-coye