Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MessageView): Improve mail when width changes #844

Merged
merged 10 commits into from
Jul 4, 2023
Merged

feat(MessageView): Improve mail when width changes #844

merged 10 commits into from
Jul 4, 2023

Conversation

valentinperignon
Copy link
Member

No description provided.

@valentinperignon valentinperignon marked this pull request as ready for review July 3, 2023 13:43
@valentinperignon valentinperignon requested a review from a team as a code owner July 3, 2023 13:43
adrien-coye
adrien-coye reviewed Jul 3, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in DM I think the JS functions could be listed in an enum, beyond that I'm ok with this PR.

adrien-coye
adrien-coye approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@valentinperignon valentinperignon merged commit c78cd61 into master Jul 4, 2023
5 checks passed
@valentinperignon valentinperignon deleted the webview-width-changed branch July 4, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valentinperignon @adrien-coye