feat: Advertise NSUserActivity #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeWeidmann
force-pushed
the
user-activity-uikit
branch
from
34a3804
to
6af5c31
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| public func setCurrentActivity( | ||
| _ activity: NSUserActivity = NSUserActivity(activityType: NSUserActivityTypeBrowsingWeb), | ||
| mailbox: Mailbox, | ||
| folder: Folder? |
There was a problem hiding this comment.
Is it ok to have a function that accepts an optional but checks directly that folder is not an optional?
valentinperignon
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we only support navigating to correct mailbox and folder as we don't share thread ids.
This only works if the connected account on the web is the same as on device.