fix: Correctly load Draft body #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeWeidmann
force-pushed
the
fix-loading-body
branch
2 times, most recently
from
4ad5385
to
0a091fb
Compare
PhilippeWeidmann
force-pushed
the
fix-loading-body
branch
from
0a091fb
to
e8b18ab
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
adrien-coye
approved these changes
Jul 6, 2023
| let shouldAddSignatureText: Bool | ||
|
|
||
| if let messageReply { | ||
| // New draft created either with reply or forward |
There was a problem hiding this comment.
This is fine right now, a "nice to have" could be to create an enum DraftOrigin and switch on it, this way we can document each case in the enum and it might be easier to read than a list of if/else. And the logic behind each case is explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write complete body in realm only once after complete loading.
Add signature after initial loading.
Only add signature for new messages, reply, forward.