Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Alert on detachAddress #865

Merged
merged 11 commits into from
Jul 13, 2023
Merged

fix: Alert on detachAddress #865

merged 11 commits into from
Jul 13, 2023

Conversation

Ambrdctr
Copy link
Contributor

@Ambrdctr Ambrdctr commented Jul 7, 2023

No description provided.

@Ambrdctr Ambrdctr requested a review from a team as a code owner July 7, 2023 11:23
@Ambrdctr Ambrdctr changed the title Detach alert fix: Alert on detachAddress Jul 7, 2023
valentinperignon
valentinperignon reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@valentinperignon valentinperignon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍
Could you update DetachMailboxConfirmationView with the updated design?

Mail/Views/Alerts/DetachMailboxConfirmationView.swift Outdated Show resolved Hide resolved
Mail/Views/Unavailable Mailbox/UpdateMailboxPasswordView.swift Show resolved Hide resolved
@Ambrdctr Ambrdctr force-pushed the detachAlert branch 3 times, most recently from 3e733e7 to 59e96fe Compare July 12, 2023 13:32
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ambrdctr Ambrdctr mentioned this pull request Jul 13, 2023
Merged
@valentinperignon valentinperignon merged commit 8073b8d into master Jul 13, 2023
5 checks passed
@valentinperignon valentinperignon deleted the detachAlert branch July 13, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann left review comments

@valentinperignon valentinperignon valentinperignon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ambrdctr @PhilippeWeidmann @valentinperignon