Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Decouple current account #892

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

PhilippeWeidmann
Copy link
Member

Ground work stop using AccountManager.currentAccount.
For now all accesses must be done using: getCurrentAccount()
In the future if we want to stop using "one current account" eg. show multiple windows with different mailboxes and accounts we will just have to replace getCurrentAccount() with getPreferredAccount().

Depends on #890

@PhilippeWeidmann PhilippeWeidmann requested a review from a team as a code owner July 20, 2023 13:32
@github-actions
Copy link

This PR/issue depends on:

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@valentinperignon valentinperignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhilippeWeidmann PhilippeWeidmann merged commit 2011812 into master Jul 21, 2023
5 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the decouple-current-account branch July 21, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants