Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rename UndoRedoAction to UndoAction #927

Merged
merged 1 commit into from
Aug 15, 2023
Merged

refactor: Rename UndoRedoAction to UndoAction #927

merged 1 commit into from
Aug 15, 2023

Conversation

PhilippeWeidmann
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann commented Aug 15, 2023 •
edited
Loading

Only renaming.

UndoRedoAction was misleading as there is no "redoing" only two steps in the undo:

  1. Api call to actually cancel the action
  2. Api call to refresh the folder where the action was done

@PhilippeWeidmann PhilippeWeidmann requested a review from a team as a code owner August 15, 2023 07:10
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PhilippeWeidmann PhilippeWeidmann merged commit 6bbba31 into master Aug 15, 2023
7 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the refactor-undo-rename branch August 15, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ambrdctr Ambrdctr Ambrdctr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhilippeWeidmann @Ambrdctr