Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling invalid signature, use default one. #931

Merged
merged 7 commits into from
Aug 18, 2023
Merged

Handling invalid signature, use default one. #931

merged 7 commits into from
Aug 18, 2023

Conversation

adrien-coye
Copy link
Contributor

No description provided.

@adrien-coye adrien-coye self-assigned this Aug 16, 2023
@adrien-coye adrien-coye requested a review from a team as a code owner August 16, 2023 11:41
@PhilippeWeidmann
Copy link
Member

Apart from the comments the rest looks good to me.

Note that we still need to stop fetching signatures when ComposeView is presented and do it at app foreground appear but this can be done in an other PR.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PhilippeWeidmann PhilippeWeidmann merged commit a788eb5 into master Aug 18, 2023
5 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the handlingInvalidSignature branch August 18, 2023 11:50
@adrien-coye adrien-coye mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees

@adrien-coye adrien-coye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrien-coye @PhilippeWeidmann