Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: External tag #945

Merged
merged 20 commits into from
Aug 29, 2023
Merged

feat: External tag #945

merged 20 commits into from
Aug 29, 2023

Conversation

Lnamw
Copy link
Contributor

@Lnamw Lnamw commented Aug 25, 2023

No description provided.

adrien-coye
adrien-coye reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a first walkthrough of the code, looking good so far 👍

MailCore/Models/Recipient.swift Outdated Show resolved Hide resolved
valentinperignon
valentinperignon reviewed Aug 28, 2023
View reviewed changes
Mail/Views/Alerts/ExternalRecipientView.swift Outdated Show resolved Hide resolved
Mail/Views/New Message/ComposeMessageView.swift Outdated Show resolved Hide resolved
Mail/Views/New Message/ComposeMessageView.swift Outdated Show resolved Hide resolved
Mail/Views/New Message/ComposeMessageView.swift Outdated Show resolved Hide resolved
Mail/Views/Thread/ThreadView.swift Outdated Show resolved Hide resolved
MailCore/Utils/Model/DisplayExternalRecipientStatus.swift Outdated Show resolved Hide resolved
@adrien-coye adrien-coye added this to the 1.0.5 milestone Aug 29, 2023
Lnamw and others added 20 commits August 29, 2023 11:23
@Lnamw
feat(ThreaView): Add external tag
c72eb4c
@Lnamw
feat: Create alert ExternalExpeditorView
b03a25e
@Lnamw
feat: Add onTagColor
ab84e30
@Lnamw
feat: Create bottom banner
9715ccc
@Lnamw
feat: Update Endpoint
24f866b
@Lnamw
feat: Update Mailbox model with new properties
4ea8282
@Lnamw
feat: Create isExternal function
8e26ac2
@Lnamw
feat: Rename and update ExternalRecipientView
d38e521
@Lnamw
feat: Create DisplayExternalRecipientStatus
20d9cd2
@Lnamw
fix: Remove comment for test purposes
c0ec251
@Lnamw
feat: Update RecipientChipLabel colors
1dac315
@Lnamw
feat: Update UI
790deb6
@Lnamw
feat: email added manually is considered as not external
07643bd
@Lnamw
fix: border color
b0fb18e
@Lnamw
feat: Matomo
aad4894
@Lnamw
fix: Code smells
5b456ec
@Lnamw @valentinperignon
Update Mail/Views/Thread/ThreadView.swift
5812f6f 
Co-authored-by: Valentin Perignon <valentin.perignon@infomaniak.com>
@Lnamw @valentinperignon
Update Mail/Views/New Message/ComposeMessageView.swift
69230c0 
Co-authored-by: Valentin Perignon <valentin.perignon@infomaniak.com>
@Lnamw
fix: feedbacks
63075b7
@Lnamw
fix: Chip color not updated on delete
3e43f34
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Lnamw Lnamw marked this pull request as ready for review August 29, 2023 11:54
@Lnamw Lnamw requested a review from a team as a code owner August 29, 2023 11:54
adrien-coye
adrien-coye approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrien-coye adrien-coye merged commit ac105ee into master Aug 29, 2023
5 checks passed
@adrien-coye adrien-coye deleted the external-message branch August 29, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon left review comments

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lnamw @valentinperignon @adrien-coye