Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash missing mailboxManager in UnavailableMailboxesView #949

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Aug 29, 2023

Abstract

UnavailableMailboxesView require to use some views without a mailboxManager

This PR solves the problem by making the subviews requiring a nullable mailboxManager at init.

@adrien-coye adrien-coye added the bug Something isn't working label Aug 29, 2023
@adrien-coye adrien-coye self-assigned this Aug 29, 2023
@adrien-coye adrien-coye requested a review from a team as a code owner August 29, 2023 08:08
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adrien-coye adrien-coye added this to the 1.0.5 milestone Aug 29, 2023
@Ambrdctr Ambrdctr merged commit 6cd6c80 into master Aug 29, 2023
6 checks passed
@Ambrdctr Ambrdctr deleted the crashMissingMailbox branch August 29, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants