Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean removed contacts from DB #955

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Clean removed contacts from DB #955

merged 3 commits into from
Aug 31, 2023

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Aug 30, 2023

Abstract

Some cleanup and minor improvements related to contacts

Tasks

fix(ContactManager): Remove contacts from DB when does not exist in iphone or infomaniak
feat(ContactManager): reduce getRealm call count.
feat(ContactManager): refresh realm on getRealm() to match the app.

feat(ContactManager): refresh realm on getRealm() to match the app.
@adrien-coye adrien-coye added this to the 1.0.6 milestone Aug 30, 2023
@adrien-coye adrien-coye self-assigned this Aug 30, 2023
@adrien-coye adrien-coye modified the milestones: 1.0.6, 1.0.5 Aug 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adrien-coye adrien-coye changed the title Some cleanup and minor improvements Clean removed contacts from DB Aug 31, 2023
@adrien-coye adrien-coye marked this pull request as ready for review August 31, 2023 08:45
@adrien-coye adrien-coye requested a review from a team as a code owner August 31, 2023 08:45
@adrien-coye adrien-coye merged commit f79c5b7 into master Aug 31, 2023
8 checks passed
@adrien-coye adrien-coye deleted the someCleanup branch August 31, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants