Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dct identifier #32

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Fix/dct identifier #32

merged 3 commits into from
Apr 14, 2021

Conversation

frederik-ronnevig
Copy link
Contributor

Etter samtale med @stigbd ble vi enige om følgende:

  • Vi kobler ikkje dagens identifier til dct:identifier
  • dct_identifier innføres som nytt felt, verdien blir eksponert i dct:identifier, og det overlates til bruker av biblioteket og evt gjenbruke (deler av) verdi frå identifier.

Vi innfører derfor ny property for alle klassene som iflg dcat-ap-no v2 har denne egenskapen.

#25 (comment)

Copy link
Contributor

@stigbd stigbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfekt!
Ein liten ting som må på plass: bump minor-version
Tips: køyr følgande kommando % poetry version minor
Evt manuelt endre version i pyproject.toml manuelt til

[tool.poetry]
name = "datacatalogtordf"
version = "1.3.0"
...

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #32 (6ca19e3) into master (b84ae64) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1339      1361   +22     
=========================================
+ Hits          1339      1361   +22     
Impacted Files Coverage Δ
src/datacatalogtordf/catalog.py 100.00% <100.00%> (ø)
src/datacatalogtordf/dataset.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b84ae64...6ca19e3. Read the comment docs.

@frederik-ronnevig
Copy link
Contributor Author

Perfekt!
Ein liten ting som må på plass: bump minor-version
Tips: køyr følgande kommando % poetry version minor
Evt manuelt endre version i pyproject.toml manuelt til

[tool.poetry]
name = "datacatalogtordf"
version = "1.3.0"
...

Takk for tilbakemelding @stigbd , da er det gjort! :-)

Fiffig å gjøre det med poetry! 👍

@frederik-ronnevig frederik-ronnevig merged commit fa6d28a into master Apr 14, 2021
@frederik-ronnevig frederik-ronnevig deleted the fix/dct_identifier branch April 14, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants