This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Feature/ois/result tabs info #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkopaas
suggested changes
Jan 9, 2019
| @@ -21,7 +21,7 @@ export function configureStore() { | |||
|
|
|||
| const enhancer = selectedCompose( | |||
| applyMiddleware(...middlewares), | |||
| persistState([/* 'featureToggle', */ 'settings'], { key: 'redux' }) | |||
| persistState(['featureToggle', 'settings'], { key: 'redux' }) | |||
There was a problem hiding this comment.
Som vi snakket, vi har en fare nå, et brukere får status lest ut fra localstorage, og den skal overstyre din "initial state".
Det ser ut til meg, at hver feature, som har noen gang vært under featuretoggle kan aldri settes tilbake igjen.
Så vi trenger noe til å overstyre den initial state som var lastet ut fra localstore. Jeg tenkte om å håndtere action @@init, men da fant jeg ordentlig løsning :
Så, featureToggle skulle håndtere FEATURE_TOGGLE_INIT action, sånn, at det filtrerer ut bare de, som vi vill være aktive nå.
state=_.pick(state, [ ...listen av nåværende toggles])
oyvindis
force-pushed
the
feature/ois/resultTabs-info
branch
from
15d143b
to
76f6fff
Compare
oyvindis
force-pushed
the
feature/ois/resultTabs-info
branch
from
76f6fff
to
05ea54d
Compare
markkopaas
approved these changes
Jan 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue link: link