Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API object BackendRuntime for expandability #134

Closed
3 tasks done
kerthcet opened this issue Sep 9, 2024 · 5 comments · Fixed by #139
Closed
3 tasks done

Add new API object BackendRuntime for expandability #134

kerthcet opened this issue Sep 9, 2024 · 5 comments · Fixed by #139
Labels
feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Milestone

Comments

@kerthcet
Copy link
Member

kerthcet commented Sep 9, 2024

What would you like to be added:

Right now, once we add a new backend support, we'll have to implement the Backend interface, and provide the default values, which means each time we want to support a new backend, we'll have to modify the controller logic. This is not that expandability considering Kubernetes has CRD intended for that. What's more, the default values can not be modified.

So let's make them a CRD Backend and export these default values by default, once admin wants to change the values, they can modify them directly.

This required the support of helm installation.

Why is this needed:

Better expandability.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@kerthcet
Copy link
Member Author

kerthcet commented Sep 9, 2024

/kind feature

@kerthcet
Copy link
Member Author

kerthcet commented Sep 9, 2024

/milestone v0.1.0

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-kind Indicates a PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a label and requires one. labels Sep 9, 2024
@InftyAI-Agent InftyAI-Agent added this to the v0.1.0 milestone Sep 9, 2024
@kerthcet
Copy link
Member Author

kerthcet commented Sep 9, 2024

This is not that hurry because we can always add an backendRuntime when we needed. However, we should consider this after we have metrics support to see how to design the API.

@kerthcet
Copy link
Member Author

kerthcet commented Sep 9, 2024

/milestone clear

@kerthcet kerthcet changed the title Add new API object Backend for expandability Add new API object BackendRuntime for expandability Sep 9, 2024
@InftyAI-Agent InftyAI-Agent removed this from the v0.1.0 milestone Sep 9, 2024
@kerthcet
Copy link
Member Author

kerthcet commented Sep 9, 2024

/milestone v0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants