Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Add warning to auto-upload when not login instead of exception #734

Merged

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Jun 13, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • when enabling auto-upload, it would strictly check whether user login status and throw exception.

Which issue(s) this PR fixes:
sc-31625

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@wcchang1115 wcchang1115 marked this pull request as ready for review June 13, 2023 07:13
Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
@wcchang1115 wcchang1115 force-pushed the bug/sc-31625/cannot-piperider-compare-without-login branch from 8faf2e4 to 8763372 Compare June 13, 2023 07:20
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@popcornylu popcornylu merged commit ff496ab into main Jun 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants