Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] sc-31590 Run command support -s to select dbt models #739

Merged

Conversation

kentwelcome
Copy link
Member

@kentwelcome kentwelcome commented Jun 14, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:

  • PipeRider run command support options -s or --select The logic will be equaled as dbt's --select option.
  • Piperider compare command support options -s or --select. But it will only be affected when no default recipe is found. If the user has provided a recipe file, we will execute the --select option and ignore the recipe file.
    https://www.loom.com/share/405d650e19dd4234adccea662342d7b7

Which issue(s) this PR fixes:
SC-31590

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
No

Signed-off-by: Kent Huang <kent@infuseai.io>
Signed-off-by: Kent Huang <kent@infuseai.io>
@kentwelcome kentwelcome force-pushed the feature/sc-31590/support-s-select-to-specify-dbt-model branch from 79cdc6b to beacd90 Compare June 15, 2023 03:20
Signed-off-by: Kent Huang <kent@infuseai.io>
@kentwelcome kentwelcome marked this pull request as ready for review June 15, 2023 04:14
…recipe

Signed-off-by: Kent Huang <kent@infuseai.io>
@kentwelcome kentwelcome requested a review from ctiml June 15, 2023 07:32
Copy link
Member

@ctiml ctiml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentwelcome kentwelcome merged commit 3b1f2d1 into main Jun 20, 2023
18 checks passed
@kentwelcome kentwelcome deleted the feature/sc-31590/support-s-select-to-specify-dbt-model branch June 20, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants