Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Adjust compare-reports command behavior #922

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Nov 3, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
chore

What this PR does / why we need it:

  • the compare-reports command filtered reports from different targets before, right now we would like to remove this limitation due to more emphasis on the base-target comparison.

Which issue(s) this PR fixes:
sc-32530

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
@wcchang1115 wcchang1115 marked this pull request as ready for review November 3, 2023 02:57
Copy link
Member

@kentwelcome kentwelcome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentwelcome kentwelcome merged commit 02b474b into main Nov 7, 2023
30 checks passed
@kentwelcome kentwelcome deleted the chore/sc-32530/adjust-compare-reports-behavior branch November 7, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants