New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix improper print #81

Merged

qrtt1 merged 2 commits into main from bug/sc-23681/bug-files-command-not-output-valid-json

Dec 13, 2021

Contributor

qrtt1 commented Dec 13, 2021

Any print call in the sdk command should go with the file kwarg.
In most case, it should be self.primehub.stderr to show error messages

fix improper print call
add a test to find out any print without the file kwarg (avoid the same problem in the future)

qrtt1 added 2 commits

December 13, 2021 15:20


          Put the status report to the stderr

e8eeed2

Signed-off-by: Ching Yi, Chan <qrtt1@infuseai.io>


          Add test_print to scan all primehub commands

a210bbc

Signed-off-by: Ching Yi, Chan <qrtt1@infuseai.io>

qrtt1 merged commit d7fa9c5 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment