Fixed bug with eject/unmount on mac

IngvarX · Mar 23, 2021 · fab506c · fab506c
1 parent 51f78bc
commit fab506c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/Camelot.Services.Mac/MacMountedDriveService.cs b/src/Camelot.Services.Mac/MacMountedDriveService.cs
@@ -7,9 +7,9 @@ namespace Camelot.Services.Mac
     public class MacMountedDriveService : MountedDriveServiceBase
     {
         private const string UnmountDriveCommand = "diskutil";
-        private const string UnmountDriveArguments = "unmount {0}";
+        private const string UnmountDriveArguments = "unmount \"{0}\"";
         private const string EjectDriveCommand = "diskutil";
-        private const string EjectDriveArguments = "eject {0}";
+        private const string EjectDriveArguments = "eject \"{0}\"";
 
         private readonly IProcessService _processService;
 
@@ -33,7 +33,7 @@ public override Task EjectAsync(string driveRootDirectory)
             var arguments = string.Format(EjectDriveArguments, driveRootDirectory);
 
             _processService.Run(EjectDriveCommand, arguments);
-            
+
             return Task.CompletedTask;
         }
     }

diff --git a/tests/Camelot.Services.Mac.Tests/MacMountedDriveServiceTests.cs b/tests/Camelot.Services.Mac.Tests/MacMountedDriveServiceTests.cs
@@ -19,9 +19,9 @@ public MacMountedDriveServiceTests()
         }
 
         [Theory]
-        [InlineData("/home/test", "diskutil", "unmount /home/test")]
-        [InlineData("/home/camelot", "diskutil", "unmount /home/camelot")]
-        [InlineData("/dev/disk1", "diskutil", "unmount /dev/disk1")]
+        [InlineData("/home/test", "diskutil", "unmount \"/home/test\"")]
+        [InlineData("/home/camelot", "diskutil", "unmount \"/home/camelot\"")]
+        [InlineData("/dev/disk1", "diskutil", "unmount \"/dev/disk1\"")]
         public void TestUnmount(string drive, string command, string arguments)
         {
             _autoMocker
@@ -39,9 +39,9 @@ public void TestUnmount(string drive, string command, string arguments)
         }
 
         [Theory]
-        [InlineData("/home/test", "diskutil", "eject /home/test")]
-        [InlineData("/home/camelot", "diskutil", "eject /home/camelot")]
-        [InlineData("/dev/disk1", "diskutil", "eject /dev/disk1")]
+        [InlineData("/home/test", "diskutil", "eject \"/home/test\"")]
+        [InlineData("/home/camelot", "diskutil", "eject \"/home/camelot\"")]
+        [InlineData("/dev/disk1", "diskutil", "eject \"/dev/disk1\"")]
         public async Task TestEject(string drive, string command, string arguments)
         {
             _autoMocker