Bugfix/shell icons path extension #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….IO.Path return different values for GetExtension
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 185 185
Lines 4830 4830
Branches 388 388
=======================================
Hits 4487 4487
Misses 288 288
Partials 55 55
☔ View full report in Codecov by Sentry. |
IngvarX
reviewed
Oct 30, 2023
| @@ -23,19 +23,14 @@ public class WindowsShellIconsService : IShellIconsService | |||
|
|
|||
| public ImageModel GetIconForExtension(string extension) | |||
| { | |||
| if (string.IsNullOrEmpty(extension)) | |||
| if (!_pathService.IsExtension(extension)) | |||
There was a problem hiding this comment.
Let's remove this check and the corresponding method in IPathService. Project standard is to avoid redundant checks especially given that extension is following the same standards across the codebase. Also IsExtension doesn't have too much value
| { | ||
| throw new ArgumentNullException(nameof(extension)); | ||
| } | ||
| if (extension.StartsWith(".")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed shell icons, which didn't work because IPathService and System.IO.Path return different values for GetExtension