This repository has been archived by the owner on May 23, 2018. It is now read-only.
Find People #2
Merged
Find People #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might add test cases in Google Drive, as mentioned in milestone 2 assignment on canvas? |
IniZio
reviewed
Nov 1, 2017
| results.append("Search Result(s):"); | ||
|
|
||
| if (resultList ==null) { | ||
| results.append("\nNot found."); |
There was a problem hiding this comment.
might want to reply and return here? when i enter an impossible input e.g. 123, it will give reply:
Search Result(s):
Not found. Too many results...
IniZio
reviewed
Nov 1, 2017
| replyToken, | ||
| reply | ||
| ); | ||
| number=1; // get input and search for name |
There was a problem hiding this comment.
might want to use a final variable to many it more understandable for later development?
e.g. number = PEOPLE_ITSC_INPUT
?
There was a problem hiding this comment.
Since other branches also use similar mechanism, will ignore this suggestion first and solve at once later
IniZio
suggested changes
Nov 1, 2017
Closed
IniZio
approved these changes
Nov 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchPeople(string) in URLConnectionReader class takes in a string and returns a list of people found. People and PeopleList classes store the information of found people.
3 Cases:
Found
Not found
Too many results