Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs updating for the latest IndieAuth changes #48

Closed
fluffy-critter opened this issue Aug 11, 2020 · 2 comments
Closed

Needs updating for the latest IndieAuth changes #48

fluffy-critter opened this issue Aug 11, 2020 · 2 comments

Comments

@fluffy-critter
Copy link

As of this past weekend, requesting an id has been deprecated in favor of requesting a code with no scope.

SelfAuth (formerly-correctly) responds with an error in the latter case, and it seems to be the only commonly-used endpoint which does, which makes for a difficult incompatibility with this protocol change since there's no way for the client to even know a scopeless code request failed and needs to fall back to an id request.

@sknebel
Copy link
Collaborator

sknebel commented Aug 11, 2020 via email

@fluffy-critter
Copy link
Author

Ah, so it is! Bit of a race condition -- I had drafted this issue last night but didn't get around to submitting it until just now, and in the meantime a pull request got opened. :) I guess I can close this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants