Changed HTML export to allow serving over https as well as http #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this properly work with the ingame browser? it is kinda outdated |
|
Yeah, I tried it, everything seems to work. |
|
actually it breaks the tabs and displays everything below each other. This breaks the /act command which i assume is the major use for the HTML export. Setting it to always https works for the ingame browser. From my understanding this should also work if you want to serve the export via http |
|
Ah, probably doesn't like it when serving from file:///. Yeah https should always be safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the reference to jquery use the scheme that the page itself was loaded over, allowing the export to be served over https without getting errors.