Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): table alignment wasn't reset properly #218

Merged

Conversation

Valentin271
Copy link
Contributor

While working on #141 I found a bug in the table alignment that I would like to fix first.

Each cell, if no explicit alignment specified, retain the alignment of the previous cell. This also occurred across table.


Assume the following table:

| left default | left forced | centered | right | left default |
| ------------ | :---------- | :------: | ----: | ------------ |
| text         | text        |   text   |  text | text         |

On main:
image

With this fix:
image

Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to mention adding a regression test, but you're already way ahead of me. Thanks!

@CosmicHorrorDev CosmicHorrorDev merged commit 5c4827e into Inlyne-Project:main Jan 21, 2024
7 checks passed
@Valentin271 Valentin271 deleted the fix/table-alignment-cache branch January 21, 2024 16:59
@CosmicHorrorDev CosmicHorrorDev added the C-bug Category: Something isn't working label Jan 21, 2024
@CosmicHorrorDev CosmicHorrorDev added the A-table Area: Dealing with markdown tables label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-table Area: Dealing with markdown tables C-bug Category: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants