Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check videos against workbook after creation #122

Closed
18 of 20 tasks
lenucksi opened this issue Aug 29, 2019 · 37 comments · Fixed by #446
Closed
18 of 20 tasks

Check videos against workbook after creation #122

lenucksi opened this issue Aug 29, 2019 · 37 comments · Fixed by #446
Assignees
Labels
Contributor good first issue Good for newcomers Video Workbook Related to the Workbook

Comments

@lenucksi
Copy link
Member

lenucksi commented Aug 29, 2019

What we have left:

  • Upload new video.
  • Update references to new video (e.g. config.yaml, playlists).
  • Rewrite question.

Rationale

The workbook contains questions based on the videos - one could consider this the take-aways.
Especially in the case of the Contributor we are creating workbook content before the videos based on the Outline and the articles.
We need to ensure that the videos and articles contain content that matches the workbook questions and makes them properly answerable.

Action items & acceptance criteria

Prior to making the videos

  • Check that the Contributor video scripts have matching content for the workbook

After making the videos

  • Check the Contributor videos for content from the workbook

Acceptance:

  • Let someone uninvolved test themselves with the workbook based on the videos.
  • Introduction
    • Seen Through
    • Clean + Pass
    • Adapted + Pass now
  • Trusted Committer
    • Seen Through
    • Clean + Pass
    • Adapted + Pass now
  • Contributor (Videos can be seen here: https://innersourcecommons.org/learn/learning-path/contributor/)
    • Seen Through
    • Clean + Pass
    • Adapted + Pass now
  • Product Owner
    • Seen Through
    • Clean + Pass
    • Adapted + Pass now
@lenucksi lenucksi added Workbook Related to the Workbook Video Contributor labels Aug 29, 2019
@rrrutledge
Copy link
Contributor

We can also do this check after creating the video scripts yet still before shooting the video itself (#140)

@lenucksi
Copy link
Member Author

Screenlight link available here: https://innersourcecommons.slack.com/archives/CARTU4XV2/p1573840051113600

@arnom-ms
Copy link
Collaborator

arnom-ms commented Apr 2, 2020

At this point the ask is to

  • Watch the video on one segment (available on our Google drive)
  • After watching one segment, review the workbook questions if the question(s) for the segment can be answered after watching the video.

@rrrutledge
Copy link
Contributor

rrrutledge commented Apr 16, 2020

@BrittanyIstenes working on this.

@BrittanyIstenes
Copy link
Collaborator

BrittanyIstenes commented Apr 23, 2020

Intro Review - Complete

Introduction - Video 3

  • Planning role is not listed in guidance doc
  • Additional resource page leads to a 404

Introduction - Video 4

  • Video script is more high level than the doc, but covers all the bases

Introduction - Video 5

  • Mentorship is talked about in the video first, Openness is listed first in the doc
  • 10% of resource into your trusted committer is not listed in doc
  • Video only focused on Mentorship and Trusted committers, but did not get back into the other principles listed in the doc

@rrrutledge
Copy link
Contributor

Here is the workbook: https://github.com/InnerSourceCommons/InnerSourceLearningPath/tree/master/workbook

Try out the assessment questions (no peeking).

@lenucksi
Copy link
Member Author

Introduction - Video 3

  • Additional resource page leads to a 404

Do we control said URL such that we could un-404 it?

@rrrutledge
Copy link
Contributor

Which URL, specifically, are we talking about?

@BrittanyIstenes
Copy link
Collaborator

https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/master/project-roles/trusted-committer.asciidoc - This leads to the 404.

@lenucksi
Copy link
Member Author

https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/master/project-roles/trusted-committer.asciidoc - This leads to the 404.

Is that URL embedded into the video? In that case fixing it would be quite a bit more of an effort.
If we have it in text in any of our repos, we could still fix it.

@rrrutledge
Copy link
Contributor

It is in our repos. Opened #251 to fix.

@BrittanyIstenes
Copy link
Collaborator

Introduction and Product Owner complete.

Product Owner question "Roles and Responsibilities" was a tricky one. The content in the video was super deep, and the wording didnt quite align from the video to the way that the question was phrased within the answer choices. I mean, it did force me to rewatch the video to check the answer reasoning, but it was a hard one.

@rrrutledge
Copy link
Contributor

Good call out.

@rrrutledge
Copy link
Contributor

Some more feedback coming soon from Brittany

@BrittanyIstenes
Copy link
Collaborator

Trusted Committer videos were solid and Workbook followed suit.

@rrrutledge
Copy link
Contributor

Great to hear! Nice work, everyone! 🙌

@lenucksi
Copy link
Member Author

Added a bunch of check boxes in the original ticket to track the state. Checked boxes according to what I've read here. Feel free to do some checkbox ticking as you see fit @BrittanyIstenes and thanks for reviewing! 😃

@rrrutledge
Copy link
Contributor

Good point about the boxes. Great way to track what's been done!

@rrrutledge rrrutledge added the good first issue Good for newcomers label May 28, 2020
@BrittanyIstenes
Copy link
Collaborator

Team, to be honest, the question albeit confusing for me is probably not that way for many. I personally think just leave it. I do not have the best mind for creating in-depth questions like this one.

@rrrutledge
Copy link
Contributor

@mtabbal interested in looking at Contributor videos vs. workbook questions.

@rrrutledge rrrutledge moved this from In Review to To do in Learning Path Segments Aug 6, 2020
@lenucksi lenucksi moved this from To do to In progress in Learning Path Segments Aug 7, 2020
@lenucksi lenucksi moved this from In progress to To do in Learning Path Segments Aug 7, 2020
@tsadler1988 tsadler1988 pinned this issue Feb 4, 2021
@lenucksi
Copy link
Member Author

@Ludmila-N might be interested in doing the review for the last few videos and @lenucksi can put up the YT links to the videos next to the items.

@Ludmila-N
Copy link
Collaborator

Ludmila-N commented Apr 20, 2021

Reviewing Contributor videos, so far the first two, I see a couple glitches with https://innersourcecommons.org/learn/learning-path/contributor/02/

  1. The video: at about 3 min 23 sec, @lenucksi suggests that you can help by providing good bugs... I'm not sure this is what I want from my contributors :)
  2. The workbook: I cannot find any specific content in this video (or accompanying transcript) speaking to Question 2. What is a productive assumption for a contributor to make when joining an InnerSource project?

What are the ways we can address both/either of these?

@lenucksi
Copy link
Member Author

Reviewing Contributor videos, so far the first two, I see a couple glitches with https://innersourcecommons.org/learn/learning-path/contributor/02/

Thanks for reviewing!

1. The video: at about 3 min 23 sec, @lenucksi suggests that you can help by providing good bugs... I'm not sure this is what I want from my contributors :)

The intent here is "bug tickets" "well written issues". At least the good ones already help tremendously, so I definitely would want them. Where "well written" means: Detailed, with reproduction step, expectations and reality, possibly even a first patch or guess at a code location. Maybe we could add a small overlay on the video?

2. The workbook: I cannot find any specific content in this video (or accompanying transcript) speaking to Question 2. What is a productive assumption for a contributor to make when joining an InnerSource project?

What are the ways we can address both/either of these?

Added a suggestion for the first. For the second one I think the intent of the question is in the correct answer and its explanation. Could we maybe replace or enhance the question so it fits the video and intent?

@Ludmila-N
Copy link
Collaborator

The intent here is "bug tickets" "well written issues". At least the good ones already help tremendously, so I definitely would want them. Where "well written" means: Detailed, with reproduction step, expectations and reality, possibly even a first patch or guess at a code location. Maybe we could add a small overlay on the video?

Understood, and you say this in a few seconds - so this was provably a self-correction, but it sounds like you're listing bugs along with bug tickets. I think the best option is to cut or mute these ~5 seconds and leave the rest as is.

@Ludmila-N
Copy link
Collaborator

Ludmila-N commented May 1, 2021

Reviewing Contributor videos, Contributor Ethos section:
Question 2 - no issues.
Question 1, answer 4 has the explanation that was never mentioned in the video, suggest rewriting this option:

Why 4 is incorrect: Getting your contribution accepted is an achievement to be celebrated. However, your involvement does not end there. You should plan to be available at a minimum to fulfil a 30-day warranty on your changes (and their impact), or even better: stay close to the community and help out with additional contributions.

Also "fulfill" is spelled with double L at the end.

@rrrutledge rrrutledge moved this from To do to In progress in Learning Path Segments May 6, 2021
@lenucksi
Copy link
Member Author

lenucksi commented May 6, 2021

Understood, and you say this in a few seconds - so this was provably a self-correction, but it sounds like you're listing bugs along with bug tickets. I think the best option is to cut or mute these ~5 seconds and leave the rest as is.

Cutting it out sounds good. Do you happen to have taken a note of the time-code such that I can just edit it out and re-upload it?
Other than that: We'll need to update parts of the website, the playlists on YT or other material with the new video code. Can you please point me to the places that need changing @tsadler1988 @voborgus ?

@lenucksi
Copy link
Member Author

"Providing good bugs" is at 3:25, "providing good issue tickets for bugs" is at 3:29
Modified video has been uploaded to the the GDrive. We need someone to re-upload it to YT, adapt the YT playlists, add the thumbnail and modify the website parts accordingly.

@rrrutledge
Copy link
Contributor

@clcoffey
Copy link
Collaborator

The modified video is now on Youtube https://youtu.be/S0Gps2AbZ7M courtesy of @Katiegilroyy Can I just change the website directly to point it to the video or do you have to do it in your repository?

@lenucksi
Copy link
Member Author

lenucksi commented Jul 5, 2021

New video is live and adapted. Remaining is adaptation of the Workbook question

@rrrutledge
Copy link
Contributor

Nice work!

@fioddor
Copy link
Collaborator

fioddor commented Jul 19, 2021

I've watched the Introduction videos and I was able to complete their corresponding workbook. I'm totally uninvolved in their creation, but on the other hand I already have some previous knowledge about open source communities, so take my feedback with a pinch of salt.

@rrrutledge
Copy link
Contributor

Thanks for this review @fioddor.

@rrrutledge
Copy link
Contributor

@lenucksi can you update the checkboxes in the description with what has been done and what is left?

@rrrutledge rrrutledge self-assigned this Aug 2, 2021
rrrutledge added a commit that referenced this issue Aug 20, 2021
@rrrutledge rrrutledge moved this from In progress to In Review in Learning Path Segments Aug 20, 2021
Learning Path Segments automation moved this from In Review to Done Sep 6, 2021
rrrutledge added a commit that referenced this issue Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor good first issue Good for newcomers Video Workbook Related to the Workbook
Projects
Development

Successfully merging a pull request may close this issue.

9 participants