Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo permission review #594

Closed
spier opened this issue Oct 10, 2023 · 6 comments
Closed

Repo permission review #594

spier opened this issue Oct 10, 2023 · 6 comments
Assignees
Labels
⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR

Comments

@spier
Copy link
Member

spier commented Oct 10, 2023

As this GitHub repository grew, so did the number of people with access to it.

In this issue we are looking to document:

  • who has access today
  • what level of permissions do they have (and why)

Based on that we want to:

  • describe how we want to handle permissions in the future
  • change the permissions of existing users to match
@spier spier added the ⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR label Oct 10, 2023
@spier spier self-assigned this Oct 10, 2023
@spier
Copy link
Member Author

spier commented Oct 10, 2023

Current status:

  • ✅ the @InnerSourceCommons/members GitHub team has READ access
    • purpose is for the repo to be shown more prominently for them in their individual GitHub account
  • ✅ the @InnerSourceCommons/patterns GitHub team has ADMIN access
    • that team was originally meant to be "the group of people who are part of the ISC patterns working group".
    • However we have used it as "the people that are trusted committers on this repo".
    • With the latter approach we ran into the issue that you need to be a member of the org, in order to be a member on the team. therefore some of the newer trusted committers that we have are not a member of this team, and have been added individually to the repo
    • note that this team is also tied to some GitHub projects. not sure how that works.
  • ✅ some individuals users have READ access
    • these users previous had more permissions but access was reduced to READ, as we did not know why they had those permissions.
    • we could remove these users from the repo now, as ALL users on GitHub have READ access to this repo by default
  • ✅ some individual users have WRITE access
    • this makes working with this repo a little bit easier for them, as they don't have to maintain their own fork to send PRs
  • ✅ Some of the owners of the InnerSourceCommons GitHub org have been added to the repo.
    • for them the following applies: "This is an organization owner. An organization owner cannot be assigned any other role (other than ADMIN)"
    • these users don't have to be added to the repo at all, as they have ADMIN access by default (by means of their org ownership)
    • we could these users from the repo, if they are not Trusted Committers at the same time. That way it would be more explicit that we give higher-level permissions to Trusted Committers only!

@spier
Copy link
Member Author

spier commented Oct 10, 2023

Removed individual READ access for users:

We could try to contact these users, to ask if they want to become more active in the Patterns WG again.
Not sure what the best way to contact the would be though.

@spier
Copy link
Member Author

spier commented Oct 10, 2023

Removed WRITE/ADMIN permissions from org owners, that are no Trusted Committers on this repo.
Effectively this does not make any difference for them, as through their org ownership they still have ADMIN to this repo.

However for the maintainers of this repo it makes a difference, as we can more clearly see who is a Trusted Committer.

@spier
Copy link
Member Author

spier commented Oct 10, 2023

@yuhattor I have everybody except the two of us from the team @InnerSourceCommons/patterns.
I have further removed the permissions that this team had on the InnerSourcePatterns repo, as instead I have added permissions for all Trusted Committers individually.

We can probably delete the @InnerSourceCommons/patterns team completely at some point. Just wanted to do an interim step first for safety reasons :)

@spier
Copy link
Member Author

spier commented Oct 10, 2023

Removed this user for now. I think I added these permissions but I forgot why:

We can always add the permissions again, should they need access.

@spier
Copy link
Member Author

spier commented Oct 10, 2023

With the improvements to the TC documentation this issue is done for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR
Projects
None yet
Development

No branches or pull requests

1 participant