Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to canonical wording for InnerSource #408

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Switch to canonical wording for InnerSource #408

merged 1 commit into from
Apr 29, 2022

Conversation

MaineC
Copy link
Member

@MaineC MaineC commented Apr 29, 2022

A long time ago we decided to call things "InnerSource" - written without space and in camel case. This pattern seems to pre-date this decision, so changing.

One note to self: There is an empty reference to "contribution negotiation" - I believe some of the teams at Europace already found out that in addition to contribution guidelines and warranty the entire contribution process starts before the submission of the code change. IIRC something like that was also part of our contributor training that I did with @lenucksi. Likely we already have the knowledge for that pattern in the community.

@lenucksi
Copy link
Member

One note to self: There is an empty reference to "contribution negotiation" - I believe some of the teams at Europace already found out that in addition to contribution guidelines and warranty the entire contribution process starts before the submission of the code change. IIRC something like that was also part of our contributor training that I did with @lenucksi. Likely we already have the knowledge for that pattern in the community.

Yes, that should be part of the contribution mechanics section.

@MaineC MaineC changed the title Switch to canonical working for InnerSource Switch to canonical wording for InnerSource Apr 29, 2022
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spier spier merged commit dbe5197 into main Apr 29, 2022
@spier spier deleted the wording-change branch April 29, 2022 11:24
@spier
Copy link
Member

spier commented Apr 29, 2022

Thanks for this fix @MaineC.
I did merge this already even though the "Link Checker" is failing, as that is a sporadic issue that the GitHub URLs seem to have. Hope it resolves itself.

For the note about "contribution negotiation":
If you want to create an issue for this with a specific activity that we could do, that would be great.

@MaineC
Copy link
Member Author

MaineC commented May 2, 2022

@spier good suggestion to move that into a separate issue - done that there: #410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants