Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Yuki Hattori (@yuhattor) as a Trusted Committer #428

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Conversation

spier
Copy link
Member

@spier spier commented Jul 21, 2022

Yuki Hattori (@yuhattor) has done fantastic work in creating the first translation of our book to Japanese.
Note: This book isn't released yet but will be live shortly.

You can see the work that he is doing, supported by various other contributors, by checking out #jp-general in Slack.

To speed up the translation process, we want to give Yuki and the other translators a maximum of autonomy and code ownership, so that they can change the translations as they see fit and handle the approval process themselves.

Therefore we are onboarding Yuki Hattori (@yuhattor) as a Trusted Committer to this repo.

Initially we are limiting his review tasks to the files/folders relevant for the translation.
For that purpose we are trying out folder-specific CODEOWNERS permissions, as shown in this PR.

However we are sure that Yuki will do a ton of great work for our patterns in general, so we expect to give him even more permissions shortly.

Onboarding steps:

  • New TC is added to this file (TRUSTED-COMMITTERS.md)
  • New TC is added to .github/CODEOWNERS, so that they get notified about new PRs automatically
  • New TC receives write access to this repository
  • New TC is added to the #innersource-patterns-tcs channel
  • New TC is praised in the #innersource-patterns channel.

@spier spier marked this pull request as ready for review July 21, 2022 15:48
@spier
Copy link
Member Author

spier commented Jul 21, 2022

GitHub shows this error but that should resolve itself once Yuki accepts the invite to this repo.
Screenshot 2022-07-21 at 18 04 58

@spier spier merged commit 6a7c1f1 into main Jul 21, 2022
@spier spier deleted the add-tc-yuhattor branch July 21, 2022 16:07
@spier
Copy link
Member Author

spier commented Jul 21, 2022

@yuhattor I sent you an invite to this repo. Once you accept that let me know, and we can test if you will get auto-assigned to PRs for JP content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant